Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Splash screen #24

Merged
merged 7 commits into from
May 24, 2018
Merged

Splash screen #24

merged 7 commits into from
May 24, 2018

Conversation

leonskim
Copy link
Member

@leonskim leonskim commented May 23, 2018

- iOS

splash-ios

- Android

splash-android

Copy link
Member

@kevinvangelder kevinvangelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do it as a patch versus just adding it to the templates?

@leonskim
Copy link
Member Author

@kevinvangelder It was from the initial idea of these two:

  1. Splash screen should be loaded, as soon as possible, before the bundle is loaded, which needs to be handled on native level for both iOS and Android. It requires changes on project files and configurations in /ios and /android directory structure that we don't include in the boilerplate.
  2. From the convo with @ryanlntn, the best practice to avoid the white flicker is to use react-native-splash-screen. (White flicker issue: [Initialization] Launch screen white flash facebook/react-native#1402)

Copy link
Member

@ryanlntn ryanlntn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@leonskim leonskim merged commit 00f23b5 into master May 24, 2018
@leonskim leonskim deleted the splash-screen branch May 24, 2018 01:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants